HadeanLake
HadeanLake
this was broken by #75467 driving remotely also is broken by it
> no manually written milling recipe check https://github.com/CleverRaven/Cataclysm-DDA/blob/98be1d4185bb06b07b18929057fef378eefd2f9e/data/json/recipes/food/milling.json#L562-L580 It looks like if there is `meal_bone_mill_1_4` - there should be `"result": "meal_bone"` with `"id_suffix": "mill_1_4", ` Like this. This seems to...
UI does not display all requirements, apparently. Dummy can only be installed in diggable terrain such as dirt and grass `"pre_flags": { "flag": "DIGGABLE", "force_terrain": true },`
Can confirm this in 0.G-stable, but not in 0.H-rc or current experimental I think it was fixed by #64949
fisher prof and fishing hobbists should know something about butchering fish
> Why not at line 4920 where we test for !remaining already? I thought since `iid_furn` almost never has value, it makes sense to check if it should still have...
There may be a problem here: https://github.com/CleverRaven/Cataclysm-DDA/blob/1a13be36d01648cbbaa206f79de5b58ed6ae62fc/src/savegame_json.cpp#L4582-L4587 Omitted mandatory json member `to_ter` does not causes an error May be out of scope of this PR #76246 And here: https://github.com/CleverRaven/Cataclysm-DDA/blob/1a13be36d01648cbbaa206f79de5b58ed6ae62fc/src/savegame_json.cpp#L4928-L4933 if...
Terrain can be `nothing` only if `to_ter` is missing or invalid, but `to_ter` is a mandatory field. Missing mandatory field is a game load breaking error. So checking for null...
I noticed `was_loaded` bool member is often used in `mandatory` and `optional` calls as second parameter. I thought maybe migrations can become `ter_furn_migrations` class instances and also have it. That...
so, this is why it was true - optional assigns default value if `was_loaded` is false and that value which is "" for `empty_string_id` overrides previously assigned null id https://github.com/CleverRaven/Cataclysm-DDA/blob/c06e515d3416d1f97de91cff677a7a87f3ef89db/src/generic_factory.h#L834-L836