Hannes Papenberg

Results 192 comments of Hannes Papenberg

Unfortunately the application in the `/cli` folder does only work when Joomla is already installed. Since the installer should also be removed when the installation is done, it needs to...

> Please add some sort of installation complete message. Otherwise no one would know if the installer has bombed out or completed > > ![image](https://user-images.githubusercontent.com/1296369/180819852-27d5899c-4f1b-4835-b3f1-9f8c50312698.png) It actually contains a success...

> Please use the same terminology and field order as in the regular web site install > > ![image](https://user-images.githubusercontent.com/1296369/180818628-4cc9cd84-473b-41b1-a237-54db032a612b.png) > > Especially as the error messages are based on the...

> Passwords should not be displayed in plain text to prevent over-the -shoulder attacks ![image](https://user-images.githubusercontent.com/1296369/180818984-f5f84a76-0fd1-41be-88bb-19229511150c.png) The symfony console package does not allow to hide this input in any way.

> Create and fill database...OK > > ==> > > Creating and populating database...OK > > Its a statement of what is happening and not a question. > > Same...

> there isn't a prebuild for 4.3 branch yet ? Not yet, but I will create a PR to fix that. I don't want to do this in this PR.

> > there isn't a prebuild for 4.3 branch yet ? > > Not yet, but I will create a PR to fix that. I don't want to do this...

> > I reordered the fields. > > why? What is the reasoning. A lot of thought went into the ordering. You asked for it... I reordered the fields the...

> > > Passwords should not be displayed in plain text to prevent over-the -shoulder attacks ![image](https://user-images.githubusercontent.com/1296369/180818984-f5f84a76-0fd1-41be-88bb-19229511150c.png) > > > > > > The symfony console package does not allow...

> Passwords should not be displayed in plain text to prevent over-the -shoulder attacks ![image](https://user-images.githubusercontent.com/1296369/180818984-f5f84a76-0fd1-41be-88bb-19229511150c.png) Fixed.