Henry Wright

Results 43 comments of Henry Wright

Hi, Ok lets go through it. >Point 2: Lets agree to disagree. Breaking current installs is a big fat dis-qualifier for PR if you ask me. You even removed the...

Yes. I thought the pressure sensor interface should be re-written as: Step 1: Enable and Calibrate Pressure Sensors A, B, C. on Pins XXX Step 2: Assign Pressure sensors A,...

"As part of any change, I think we probably need to improve some of the wording on these options to indicate exactly what they refer to. 'External Baro sensor' has...

I have updated the "Calibrate Pressure Sensors" menu. It now groups together all the pressure sensors including Fuel pressure and Oil pressure on one page. Removed references to "internal" and...

> In `readBaro()` you've got the new code for checking the MAP reading (https://github.com/noisymime/speeduino/pull/670/files#diff-cf6893cab52605f0de8b25fc56b15565daa8ea927d1ca9ed99a47ea299d71fcbR493) and updating it, but nothing to prevent this reading happening when the car is running. >...

Ok, as per discussion in #development. You can enable Baro sensor and assign it to the same Pin as the MAP sensor with no code changes to use the default...

I have no more changes for this PR. If approved pull it in.

Requesting again that this PR be pulled in. I merged to the latest master and added a small change to make it more efficient. To recap this PR does the...

Hi, This PR looks great, also fixes the initalisation problems I saw with my PR https://github.com/noisymime/speeduino/pull/670 Would you consider also merging the replacement for FILTER_ADC that I put #670 which...

If the problem is on ethanol, should the cranking advance depend on the flex fuel input? i,e instead of "off or "on" it could be a threshold for ethanol %...