Clair3 icon indicating copy to clipboard operation
Clair3 copied to clipboard

pass reference to htsfile for better cram support

Open ASLeonard opened this issue 11 months ago • 1 comments

Although cram files are supported, I believe it only works if you have internet connection to download or a local cache of the reference genome. Without these you get decode errors like these

[W::find_file_url] Failed to open reference "https://www.ebi.ac.uk/ena/cram/md5/<your chromosome hash>": Connection refused

Since a reference is always required for variant calling, it is safe to always pass the reference to htslib when opening sam/bam/cram files. I tested this for a few different files with fairly default parameters and it worked fine, but I didn't test all possible modes.

ASLeonard avatar Feb 29 '24 09:02 ASLeonard

@ASLeonard Billion thanks for the PR! Will test then.

zhengzhenxian avatar Mar 01 '24 06:03 zhengzhenxian

Merged into v1.0.6.

aquaskyline avatar Mar 16 '24 01:03 aquaskyline