Hardy Hobeck

Results 163 comments of Hardy Hobeck

The `hotfix` branch inherits from the `main` branch and gets the `IncrementStrategy.Minor`. Why would you expect that the patch number increases!? And I don't understand why you would create a...

Hmm I see... With the refactoring of https://github.com/GitTools/GitVersion/pull/3190 the BaseVersionCalculator class has not been survived. That means your refactoring is obsolete IMO. Sorry for that! But if I see your...

> On another subject, while I've got you here, what do you think of this behavior illustrated above? > > ```cs > fixture.AssertFullSemver("2.0.0+1"); > fixture.Repository.ApplyTag("2.0.0+1"); > fixture.AssertFullSemver("2.0.0"); // shouldn't it...

Please integrate your ideas and help us to realize https://github.com/GitTools/GitVersion/issues/3041 and contribute for version 6.x. I'm going to close this PR because it makes no sense anymore. Thank you very...

The problem is not located in ReferenceName.cs class it is lcoated in GitPreparer.cs: ![image](https://user-images.githubusercontent.com/56404113/222884731-ee750596-5da5-4fac-a62a-621ec1ce3a71.png) **I don't know what the intention of checking isRef is but what I agree with: This...

I don't understand the intention of replacing `refs/` with `refs/heads/`. It only affects remote and pull request branches. We have already a definition in ReferenceName.cs which I would like to...

The problem is clear of course git-version doesn’t know which branch the right branch is to use. Because we have two parents on the one hand the main and on...

The trick is to specify the feature branch with increment minor not inherit.

Hi @dramdrung. Please rebase your PR with the main branch and give me feedback when you are done.

Has been resolved with PR https://github.com/GitTools/GitVersion/issues/2336 without the need of specifing IsRelease to true for Hotfix branches.