Hernando Castano

Results 68 comments of Hernando Castano

@SilentCicero been quite a long night, don't ya think 😂

The metadata will be bumped with https://github.com/paritytech/ink/pull/1100

@statictype FYI, this is one of the issues we talked about earlier today

Whenever you have time, don't worry about it!

I saw that you and @xgreenx had some discussions about this on Element. Do you mind re-posting any important bits from there here? Can you also post a link to...

Marking this as low priority since it'll become obsolete with #1134. If anybody can't get their contract compiling by manually implementing `SpreadAllocate` let us know here.

> 1. Hernando suggested renaming the `KeyHolder` trait into the `StorageKey` trait. During the previous review iteration, we decided to use the naming `KeyHolder` and we tried to remove all...

~~Hi @JayPavlina, what you're presenting isn't valid Rust (see this [Rust playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=9e6bd529c234c22f6c19a8b98c546e5e)).~~ ~~What you're likely looking for is `&mut token`.~~

> He described a valid rust:) > [Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=251ff6bcbaa41aabc68a35b9818b1bd3) I misread it, good catch 😅

@Robbepop We might want to have a separate issue for discussions and designing generics - I can't find anything in the issue tracker