Tom Herrmann
Tom Herrmann
Found the `\Illuminate\Database\Eloquent\Concerns\HasAttributes::originalIsEquivalent()` method during code diving and it should be usable for our trait! 🎉 This PR would be mainly reasearch when that method was added, if it's compatible...
- Larastan Version: 1.0.3 - `--level` used: 7 - https://github.com/phpstan/phpstan-strict-rules ### Description As there's an argument for the environment Method it will always return a boolean. The string return type...
The `translation()` should be refactored to the new `hasOne()->ofMany()` relationship type. https://laravel.com/docs/9.x/eloquent-relationships#has-one-of-many https://github.com/Astrotomic/laravel-translatable/blob/6f2e3855836d46ab7ad3dabd269a400404f8b42c/src/Translatable/Traits/Relationship.php#L64-L69
Please comment if you have a reason why the method should stay `public` and be added to the public API. **visibility:** * [x] `\Astrotomic\Translatable\Translatable::getLocaleKey` * [x] `\Astrotomic\Translatable\Traits\Relationship::getTranslationModelName` * [x] `\Astrotomic\Translatable\Traits\Relationship::getTranslationModelNameDefault`...
The fallback logic should get moved out of the trait into dedicated class(es) which could be easily replaced by custom user logic without adjusting the whole trait. It should be...
As you can see below the current `YW` format results in wrong year week combinations for end/start of year days/weeks. A curent example 2021/2022 - the first days of January...
#### What is this feature about (expected vs actual behaviour)? MacOS filesystem replaces German (single character) umlaute with a two characters since Big Sur or only on M1 machines. These...