GroteGnoom

Results 79 comments of GroteGnoom

> Hi. Yes, I was waiting for feedback. I apologize for not sending a reminder, I got caught up with other work. I would like to resume working on this...

Could you add the function to src/CMakeLists.txt and the test to tests/CMakelists.txt? Then the tests will run. Tests you could add: - [x] A graph with 1 vertex, no edges....

I was just trying things, and ran this test: ``` { igraph_t g; igraph_vector_int_t terminals; igraph_real_t value; igraph_vector_int_t tree_edges; igraph_full(&g, 10, IGRAPH_UNDIRECTED, 0); igraph_vector_int_init_int(&terminals, 9, 0, 1, 2, 3, 4,...

@Nachiket18 @RonakGSahu I think the best way to go forward is to only fix the essential stuff, test thoroughly and then merge this. So for now, ignore all my comments...

> As per our understanding the result should have 4 edges since the graph is complete (Each edge connects two terminals). But it's a single connected tree, right? And a...

I'm not arguing that any nodes are not connected. A Steiner tree should be a tree. A tree with n edges cannot connect more than n + 1 nodes. Also,...

Great! There's now also this issue: > (And when I try the test with 2 terminals it gives me an error.) ``` Fatal error at src/paths/steiner.cpp:89 : The Subset's index...

> @GroteGnoom - For the terminals 0,1,2,3 which graph was used? Was it same as the one with 9 terminals? I can reproduce the test and see where the code...

> > -DUSE_SANITIZERS=Address > > Thanks. I tried to configure using this command cmake /home/nachiket/igraph/build -DUSE_SANITIZERS=Address and then build the code but while testing the stack trace is not produced...

If I have an undirected line: > igraph_small(&graph, 5, IGRAPH_UNDIRECTED, 0,1, 1,2, -1); and I do a subset betweenness between source 0, and target 2: > igraph_vss_range(0, 1), igraph_vss_range(2,3)) Then...