GroteGnoom

Results 79 comments of GroteGnoom

Ah, I interpreted the 0.11 milestone as 'has priority over issues without a milstone, but lower priority than 0.10.x'. I don't really know how to use 'if we do it,...

With my current schedule, I don't think I should continue on this. The gaps between working on this are too big, so it takes a lot of effort every time...

This has the same snag as subset betweenness: partially overlapping vertex selections for the undirected case need special care. (see https://github.com/igraph/igraph/pull/2352#issuecomment-1574811358)

Doesn't that take an unnecessary amount of time? `igraph_get_adjacency()` loops through all edges to take their `to` and `from`s. For the `submatrix` variant I think going through all edges and...

> How about this? > > - Create a bool array `is_target` where `is_target[v]` is true is `v` is a `to` vertex > - For each `from` vertex `s`: >...

I think that just solves everything :slightly_smiling_face: There could be performance improvements, including your suggestion. I think this also shows the betweenness_subset problem in matrix form: neither the upper triangle...

> It is not ready, loop edges are not handled. I think they are? (the TODO can be removed I think) But it's still a mess, so I'll at least...

I think this https://dev.azure.com/igraph-team/igraph/_build/results?buildId=5553&view=logs&jobId=bbfa2fa6-a202-51ab-3559-6013e9e5f686&j=bbfa2fa6-a202-51ab-3559-6013e9e5f686&t=46cc7337-1682-57f5-be99-ed9c70724455 ``` [191/194] Resolving includes in DocBook XML source FAILED: doc/igraph-docs-with-resolved-includes.xml /home/vsts/work/1/s/build/doc/igraph-docs-with-resolved-includes.xml cd /home/vsts/work/1/s/build/doc && /usr/bin/xmllint --xinclude --output igraph-docs-with-resolved-includes-tmp.xml igraph-docs.xml && /usr/bin/python3.10 /home/vsts/work/1/s/tools/removeexamples.py igraph-docs-with-resolved-includes-tmp.xml igraph-docs-with-resolved-includes.xml && /usr/local/bin/cmake...

What's the status of this PR? @valdaarhun are you waiting for us before you continue?