Griffsano

Results 16 comments of Griffsano

Thanks for implementing ccxt. I think this also really helpful for solving the other open issues. I've noticed one unintended behavior with the current state of this pull request: It...

Ah ok. What about a warning then when the CSV exports are read-in and the respective exchange is not listed in the config.py? Just to make the user aware that...

Hey @scientes, for the `ohlcv-batch` branch, I'm getting inaccurate price data for Kraken exports (see table below). The fetched prices are constant over multiple timestamps. I'm working on commit bbd8bb81b9c2219d0c4c96e43d32ef3fc2312772,...

Just to let you know, I've tested this PR with my Binance/Coinbase logs and it worked flawlessly :) Awesome graph-theory-based path finding approach, thanks for implementing!

Hey @provinzio, I updated the README according to our discussion in #64: https://github.com/Griffsano/CoinTaxman/blob/margin_kraken/README.md#future---margin-trading This should contain all relevant information regarding my conception for margin taxation (if it's not clear, I'll...

Hey @provinzio, I merged the current main branch into this PR and made the necessary changes so that margin evaluation for Kraken works again. Could you please review? I updated...

From what I've seen, the problem with Coingecko is that there's only daily historic data available. CryptoCompare offers daily/hourly/minutely historic OHLCV data, but apparently only for certain coins: https://min-api.cryptocompare.com/documentation There...

Exactly, the question is how to define if the user did something to get the airdrop. For example, some airdrops are distributed to investors achieving a certain trading volume within...

From what I've seen in the CSV exports and API documentation, we probably have to access the API with a key anyways to get the timestamp of order execution. If...