Greg Grothaus
Greg Grothaus
I'll keep it in mind when I have the time, but at the moment probably no. My javascript also isn't good enough to know what I'm doing.
This makes sense. Do you have any data on if such a change would break existing email publishers? I'm concerned as this is a pretty common tag and may be...
@ampproject/wg-caching as this would be a validation change.
As a quick update, the `` tag has been deprecated in AMP4EMAIL since June 2019. The remaining open question is if and when to move from deprecated to disallowed.
I think we've backed ourselves into a bad state here, one that is confusing beyond just the error message. After reviewing this a little bit, I'm not super happy that...
@samouri @choumx to determine next steps for amp-script in runtime.
@choumx Does that mean you prefer option (3)? We can do a little more here and provide a very specific message for this invalid attribute, if useful.
Just a random drive-by comment without understanding the full scope. It might be possible to port https://github.com/ampproject/amphtml/blob/master/validator/js/engine/parse-url.js fairly easily (it's fairly minimal and doesn't have any javascript-specific bits or dependencies).
Fair enough, drive-by comment retracted. :)
For the cache piece of this, do we want to disable all URL rewrites inside a `` tag, or should we try to be smarter? For example, we could rewrite...