Graylin Kim
Graylin Kim
Can you talk about what sort of testing your "running it on all the WCS replays" entails? Is there some specific script you are running to make sure all the...
Hi, sorry, not ignoring you. I am currently moving to a new apartment and can't look at this right now. I'll review and merge as soon as possible, thanks for...
You broke the build! Likely it is because the code isn't Python3 compatible; all new contributions need compatibility. I advise putting the following at the top of every file so...
There is a map attribute: https://github.com/GraylinKim/sc2reader/blob/master/sc2reader/plugins/replay.py#L64 But now that I look at it I don't think it will work like it used to. The toJSON code was gifted by someone...
What is your use case for the JSON plugin @qpautrat? Back when it was first written it encompassed almost all of the information available. Now-a-days it doesn't even come close...
Okay @qpautrat, its going to be a busy couple weeks for me. Why don't you try adding the data you are looking for and pull request the solution that worked...
The sc2json script should be extended to provide more data and cover all major resource types.
Hi, thanks for volunteering! I would still like to maintain the sc2json script. I would also like to deprecate the `toJson` plugin. Instead, I'd like to have sc2reader implement a...
Yes, I saw the request. Thanks. I won't have time to look at this until this weekend.
Examine some results by hand first. Once you are happy with them it would be good to run over the whole set of replays; they cover a wide variety of...