Ryan McConnell

Results 30 comments of Ryan McConnell

I was a bit lost putting this together. With the `varargs` ast spec and `implicitConv`. I also think that `actingF = f[0]` should be `actingF = f.base` but I don't...

> Did you end up using this in a larger project? I haven't used this yet beyond writing tests cases. I plan on using it for some home automation ESP32...

> We should add both test cases you mentioned in https://github.com/nim-lang/Nim/issues/23755#issuecomment-2187859094. If it's intentional because you will address the first one later, carry on. Yea I don't have a lot...

CI failing, but idk, it looks like http connection issues. This is where I'm at anyway: Both of these "fixes" are dirty workarounds. The code near `getOrdValue` might actually be...

Although this is kinda obvious, I should mention what is happening: In `typeRel`'s `tyArray` branch the range of the array is processed via `inferStaticsInRange`. In that proc, families of functions...

If this passes the CI, it seems like the workaround can be removed from `inferStaticsInRange` as well (at least for the givin test cases). I'll probably be asleep by the...

> @Graveflo > > I'm guessing [this call to `reduceToBase`](https://github.com/nim-lang/Nim/blob/2c83f94544b9acc6d06fd6b7fcf035e5cb0aa8eb/compiler/sigmatch.nim#L1262) is the culprit, is it needed? According to the declaration of `reduceToBase`: > > ```nim > proc reduceToBase(f: PType): PType...

Besides I have a suspicion this might be related to the inferred return type downgrading instead of this function. Can see "Need to devalue isInferred" from the PR text: https://github.com/nim-lang/Nim/pull/23137

> I was asking if removing that line would result in any wrong behavior. I can't think of any side effects that the CI won't catch.. That is, as they...

reduced: ```nim type BigInt*[bits: static int] = object limbs*: array[8, uint64] type Limbs*[N: static int] = array[N, uint64] proc view*(a: Limbs) = discard proc view*(a: var Limbs) = discard var...