Irakli Gozalishvili
Irakli Gozalishvili
Personally I'm leaning towards option 2, which I'd re-frame as: 1. Deprecate `bytes` field in CID class 2. Drop `bytes` field in `Link` interface (it's new enough to not cause...
> I guess the data model form would always be something like `[&Any]` I would argue we do need sets at the data model layer as well. It really is...
Is solution proposed in #12 acceptable or is introduced dependency on `buffer` there is not acceptable ?
I would assume you could use static `or` function to compose all decoders together (so you could pass it to reduce directly) https://github.com/multiformats/js-multiformats/blob/a4f998bdcd18088b8a37ce129ad543aa9c8aae08/src/bases/base.js#L165-L175 because b32.decoder should be compatible because it...
I'll create pull request that adds a test with this
I've investigated this further and issue is that TS fails to infer types properly, specifically it can't decide if it should treat first arg of reduce as Decoder or ComposedDecoder...
@achingbrain is manually composing with `.or` is too inconvenient ? I know it would be more lines of code, but things would compose as they should without having to resort...
> No, because then this errors with expression of type 'string' can't be used to index type...: BTW when you use `Object.keys` and then access properties by those keys TS...
It looks like that current version works fine specifically `import('https://cdn.skypack.dev/[email protected]')`, I suspect problem may have been one of the dependencies been resolved to a newer package was breaking the build.
Instead of writing up an interface here, I've created https://github.com/multiformats/js-multiformats/pull/261 so it's easier to provide feedback inline and iterate