core-util-is icon indicating copy to clipboard operation
core-util-is copied to clipboard

Remove node-specific reference to Buffer

Open pnlp-dev opened this issue 5 years ago • 2 comments

https://github.com/isaacs/core-util-is/blob/a177da234df5638b363ddc15fa324619a38577c8/lib/util.js#L103

This references to Buffer makes this library incompatible in the browser because Buffer is part of the node API and is not available in the browser. Given that this library is imported by several other libraries that aim to make use of it in the browser, would you ever consider removing this reference?

Later versions of Angular (6+) have tightened their compile-time requirements to alert node-specific references like this which is why these issues are being surfaced now.

pnlp-dev avatar Jul 19 '20 17:07 pnlp-dev

Is solution proposed in #12 acceptable or is introduced dependency on buffer there is not acceptable ?

Gozala avatar Nov 04 '20 18:11 Gozala

No

danielehrhardt avatar Jan 07 '22 13:01 danielehrhardt