Irakli Gozalishvili

Results 654 comments of Irakli Gozalishvili

> Now that you’re considering a breaking change (deprecating isCID) I should note that there’s a future upgrade to `multiformats` which is also a breaking change to CID, among other...

We had a higher bandwidth exchange today and have settled on the following course of action: Phase 1: Implement - Add `CID.asCID` method. - Upgrade all the internal uses (codecs,...

@mikeal do you mind creating a markdown file in the repo that warning could point at. I think you have much clear understanding of this than anyone else.

> sigh, static isn’t supported widely enough yet. For instance, it’s not in the default eslint grammar which means it isn’t in the default standard grammar 😥, so we’ll need...

> We should not move to instanceof checks. > > instanceof checks can’t be used reliably when handing class instances to third party consumers because the pointer check won’t work...

> That’s because aegir uses some other eslint plugins that support the grammer. Here’s what happens with latest standard. Right I was referring to static methods which are ok, static...

> yes this is what i was suggesting, which assumptions are we breaking ? ```js const {codec, version, multihash, multibaseName } = new CID(...) const v = {codec, version, multihash,...

Above being said, I think it would be better to not rely on instance methods and instead migrate to static methods so above would translated to: ```js if (CID.isCID(v)) {...

> Can someone point me to what toV0 is used for? > > V0 conversion is so limited (dagpb only) I’m having a hard time figuring out what this is...

> Got it, I guess I would like to find a solution that could be applied to all the other modules that use class-is. Something like this https://github.com/feross/is-buffer/blob/master/index.js I think...