Irakli Gozalishvili

Results 654 comments of Irakli Gozalishvili

> These seem to be more motivated by type system tooling preference than JS ergonomics. I’ve used this library quite a bit and being able to think about a serialized...

Just noticed there's open issue on `toJSON` #57 method. Anyway my intent in regards to`CID.fromJSON` was to make following true: `cid.equals(CID.fromJSON(cid.toJSON()))`

I think there are lot of assumptions here made that this proposal is to make types easier or that it would make people’s life harder - Truth is, it’s quite...

@achingbrain you may disagree, but as I said it has being my struggle with IPFS - my brain might be wired differently from yours, but I often need to understand...

> Can we just call it `fromString()`? We don’t accept strings that aren’t multibase encoded so... I just wanted to make method names correspond to their opposites in this case...

I would like to reboot this conversation! In the light of `CID` as `ArrayBufferView` currently overloaded CID constructor is even more problematic. I wrote a [pull request against js-multiformats](https://github.com/multiformats/js-multiformats/pull/29) to...

> I don't buy the arguments you have for retaining constructors, making this thing _feel_ like an ArrayBuffer would probably mean we've failed to make it a nice abstraction. That...

> Basically, you want the constructor to just take whatever the from and create methods can parse out of the input so that you can avoid unnecessary work for certain...

We have discussed this on the call today and tentatively reached an agreement on the following plan: _@achingbrain you were not present at that part of the call, so please...

> So, the new CID is actually: >```ts > { > version: 0|1, > code: int, > multihash: Uint8Array, > buffer: Uint8Array >} >``` What's does the `buffer` represent there...