generative-ai icon indicating copy to clipboard operation
generative-ai copied to clipboard

fix: allow product_attributes_extraction.ipynb to run on Vertex colab enterprise

Open tianli opened this issue 1 year ago • 2 comments

Vertex AI colab enterprise does not allow fetching of external URI in Part.from_uri(), only gcs path (gs://...) is allowed. Therefore adding a function to load external image from URL and create the prompt part using Part.from_data().

Description

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [X] Follow the CONTRIBUTING Guide.
  • [X] You are listed as the author in your notebook or README file.
    • [X] Your account is listed in CODEOWNERS for the file(s).
  • [X] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • [X] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • [ ] Appropriate docs were updated (if necessary)

tianli avatar Aug 06 '24 00:08 tianli

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Can you also resolve the new notebook linter errors?

holtskinner avatar Aug 06 '24 13:08 holtskinner