generative-ai icon indicating copy to clipboard operation
generative-ai copied to clipboard

feat: end-to-end supervised fine-tuning for text classification

Open gabrielahrlr opened this issue 1 year ago • 7 comments

Description

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ X] Follow the CONTRIBUTING Guide.
  • [ X] You are listed as the author in your notebook or README file.
    • [ X] Your account is listed in CODEOWNERS for the file(s).
  • [ X] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • [ X] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • [ X] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

gabrielahrlr avatar Jul 31 '24 13:07 gabrielahrlr

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Is this PR supposed to be a replacement for #787 ?

holtskinner avatar Jul 31 '24 13:07 holtskinner

Yes. Currently fixing the notebook format and lint errors. Will update it soon.

gabrielahrlr avatar Jul 31 '24 13:07 gabrielahrlr

@holtskinner I went through all the errors from lint code base and lint notebook errors and fixed them. The remaining ones make no sense to me. As per spelling errors, the errors are words likeICML (where dataset was published) last names from the authors of the dataset, automl and lopgrobs, which are not spelling errors.

gabrielahrlr avatar Aug 02 '24 08:08 gabrielahrlr

I've added some of the terms to the spelling allowlist. You can see the remaining errors in the summary. It explains what the errors are and what they should be.

https://github.com/GoogleCloudPlatform/generative-ai/actions/runs/10254677291?pr=919

holtskinner avatar Aug 05 '24 19:08 holtskinner

Thanks Holt! All Spelling errors are now fixed. The Lint Notebook and Lint Code errors remain, as I have made different changes but nothing fix them.

gabrielahrlr avatar Aug 06 '24 10:08 gabrielahrlr

I would also recommend putting the methods in the python file in the notebook itself so the users won't need to download another file when using colab.

holtskinner avatar Aug 06 '24 14:08 holtskinner

@holtskinner fixed all errors and refactored as per suggestions. Erwin has recommended to have the "migration" functions separately for portability, but overall I agree that having inside the same colab is easier, so just put them back in the notebook as well and deleted the separate file.

Many thanks for all the great feedback. LMK if sth else needs to be changed to finally merge it into main :)

gabrielahrlr avatar Aug 12 '24 15:08 gabrielahrlr