generative-ai icon indicating copy to clipboard operation
generative-ai copied to clipboard

Variable name in 'reduce' step

Open the-data-guy opened this issue 2 years ago • 5 comments

Function argument is "summary" while what is being used in the function is 'initial_summary'. Fixing this.

the-data-guy avatar Jun 22 '23 05:06 the-data-guy

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Hi @the-data-guy , could you kindly reduce the files changed to just what you are describing with the summary variable fix? Thanks!

polong-lin avatar Jun 28 '23 09:06 polong-lin

Oops. Sorry about that. Please check now.

the-data-guy avatar Jul 02 '23 23:07 the-data-guy

Reopened after incorporating feedback by @polong-lin

the-data-guy avatar Jul 02 '23 23:07 the-data-guy

@iamthuya can you have a look?

erwinh85 avatar Jul 05 '23 17:07 erwinh85

Thanks for flagging this @the-data-guy. I have renamed the function parameter to initial_summary to reflect better. Will be closing this.

iamthuya avatar Jul 26 '23 05:07 iamthuya