generative-ai icon indicating copy to clipboard operation
generative-ai copied to clipboard

feat: Creating "Using Gemini with BigQuery through Remote Functions"

Open shanecglass opened this issue 1 year ago • 4 comments

shanecglass avatar Jan 10 '24 17:01 shanecglass

nit: I'm not super familiar with terraform, but would it be possible to put all of the .tf files in a directory to make it easier to navigate the files?

holtskinner avatar Jan 10 '24 19:01 holtskinner

I think the src/ directory should be removed and any changes integrated into the other files of the code.

holtskinner avatar Jan 10 '24 20:01 holtskinner

nit: I'm not super familiar with terraform, but would it be possible to put all of the .tf files in a directory to make it easier to navigate the files?

This could be done, but it would be a decent amount of work to migrate. How big of an impact do you think this will have?

shanecglass avatar Jan 10 '24 20:01 shanecglass

nit: I'm not super familiar with terraform, but would it be possible to put all of the .tf files in a directory to make it easier to navigate the files?

This could be done, but it would be a decent amount of work to migrate. How big of an impact do you think this will have?

Ok, I didn't know if it would be a major change. Don't worry about it then, just leave the tf files as is

holtskinner avatar Jan 10 '24 20:01 holtskinner

I think the src/ directory should be removed and any changes integrated into the other files of the code.

I haven't done so because it would significantly reduce the readability of the Terraform code

shanecglass avatar Jan 11 '24 15:01 shanecglass

I think the src/ directory should be removed and any changes integrated into the other files of the code.

I haven't done so because it would significantly reduce the readability of the Terraform code

Clarification on my comment, it looked like the code in src/ was duplication of code outside of src/. I'm fine with keeping the src/ directory, I just didn't want duplicate files. Is it possible to remove one or the other? Or explain what the differences are between them?

EDIT: Never mind, looks like the files not in src/ were removed in bc086cf

holtskinner avatar Jan 11 '24 16:01 holtskinner

I think the src/ directory should be removed and any changes integrated into the other files of the code.

I haven't done so because it would significantly reduce the readability of the Terraform code

Clarification on my comment, it looked like the code in src/ was duplication of code outside of src/. I'm fine with keeping the src/ directory, I just didn't want duplicate files. Is it possible to remove one or the other? Or explain what the differences are between them?

EDIT: Never mind, looks like the files not in src/ were removed in bc086cf

Ah yes! I mistakenly duplicated the SQL files in a second directory, but I removed that duplication while reviewing your feedback on it

shanecglass avatar Jan 11 '24 16:01 shanecglass