generative-ai icon indicating copy to clipboard operation
generative-ai copied to clipboard
verified publisher icon GoogleCloudPlatform

fix: Fixed Lint/Format Errors

Open holtskinner opened this issue 1 year ago • 4 comments

Follow up to #329

holtskinner avatar Jan 09 '24 18:01 holtskinner

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Jan 09 '24 20:01 review-notebook-app[bot]

I would like @RajeshThallam to look over the change to matching_engine.py since he created it in #70

Was there a particular reason for creating a custom LangChain class for MatchingEngine? Has the LangChain implementation been updated since to serve the same use cases?

holtskinner avatar Jan 09 '24 20:01 holtskinner

@holtskinner the existing langchain integration does not support a few features that the use case/notebook refers to. E.g. streaming indexes, full data point retrieval. I am working on the langchain PR to add these features along with new vector search features that were launched.

RajeshThallam avatar Jan 09 '24 21:01 RajeshThallam

Thanks @RajeshThallam that makes sense. I'll leave that file alone for this PR.

holtskinner avatar Jan 09 '24 21:01 holtskinner