generative-ai icon indicating copy to clipboard operation
generative-ai copied to clipboard

chore: Ran formatter

Open holtskinner opened this issue 1 year ago • 1 comments

holtskinner avatar Jan 05 '24 22:01 holtskinner

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Attempting to fix this mypy error, not sure of the cause:

The exact same commit didn't have this error on a first run, but had it on a later run. I'm thinking something changed in the action itself to cause this behavior.

------
2024-01-08 19:42:54 [ERROR]   Found errors in [mypy] linter!
2024-01-08 19:42:54 [ERROR]   Error code: 2. Command output:
------
WARNING: The directory '/github/home/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.
Collecting types-protobuf
  Downloading types_protobuf-4.24.0.20240106-py3-none-any.whl.metadata (1.9 kB)
Collecting types-requests
  Downloading types_requests-2.31.0.20240106-py3-none-any.whl.metadata (1.8 kB)
Collecting urllib3>=2 (from types-requests)
  Downloading urllib3-2.1.0-py3-none-any.whl.metadata (6.4 kB)
Downloading types_protobuf-4.24.0.20240106-py3-none-any.whl (62 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 62.3/62.3 kB 6.4 MB/s eta 0:00:00
Downloading types_requests-2.31.0.20240106-py3-none-any.whl (14 kB)
Downloading urllib3-2.1.0-py3-none-any.whl (104 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 104.6/104.6 kB 14.2 MB/s eta 0:00:00
Installing collected packages: urllib3, types-protobuf, types-requests
Successfully installed types-protobuf-4.24.0.20240106 types-requests-2.31.0.20240106 urllib3-2.1.0

Notice:  A new release of pip is available: 23.3.1 -> 23.3.2
Notice:  To update, run: python -m pip install --upgrade pip
mypy: can't read file '/venvs/mypy/lib/python3.11/site-packages//google': No such file or directory
Installing missing stub packages:
/venvs/mypy/bin/python -m pip install types-protobuf types-requests

Update - I think the issue was in a few files that did this import. I changed the structure and the mypy issue seems to be gone?

import google.cloud.logging

Update 2 - Not entirely sure that was it. But I'm leaving out a couple of the problematic files in hopes that they fix the issue. matching_engine.py and multimodal_rag_utils.py

holtskinner avatar Jan 08 '24 21:01 holtskinner