Update matching_engine_utils.py to support more dynamic parameters

[dvmorris]

[dvmorris]

Yes, I think that's a great idea, sorry I didn't think about that before submitting.

On Wed, Aug 23, 2023, 12:14 PM Rajesh Thallam @.***> wrote:

@.**** commented on this pull request.

Thanks for contributing. Added a minor comment.

In language/use-cases/document-qa/utils/matching_engine_utils.py https://github.com/GoogleCloudPlatform/generative-ai/pull/166#discussion_r1303318325 :

     self.project_id = project_id

     self.region = region
     self.index_name = index_name

•    self.index_endpoint_name = f"{self.index_name}-endpoint"
  

•    self.index_endpoint_name = index_endpoint_name
  

To avoid breaking changes, can we make index_endpoint_name as optional and then default to {index_name}-endpoint.

— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/generative-ai/pull/166#pullrequestreview-1592063768, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNPDLHQJN3IJN3ZG2ARC3XWY3AJANCNFSM6AAAAAA3Y2OPXY . You are receiving this because you authored the thread.Message ID: @.***>

[polong-lin]

@RajeshThallam Could you do a final check and approve? I can merge after your approval