generative-ai icon indicating copy to clipboard operation
generative-ai copied to clipboard

fix: asyncio import, removed model revision pinning and table grouping arg

Open vadakattu opened this issue 1 year ago • 4 comments

vadakattu avatar Oct 03 '24 10:10 vadakattu

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@polong-lin @alokpattani Seems owlbot post processor keeps eating the asyncio import line

vadakattu avatar Oct 03 '24 10:10 vadakattu

@polong-lin @alokpattani Seems owlbot post processor keeps eating the asyncio import line

Autoflake is removing the import because it's not being used in the notebook. Why is asyncio needed?

holtskinner avatar Oct 03 '24 20:10 holtskinner

@polong-lin @alokpattani Seems owlbot post processor keeps eating the asyncio import line

Autoflake is removing the import because it's not being used in the notebook. Why is asyncio needed?

@holtskinner the second half of the notebook is about async execution to process multiple videos. It's a problem with the linter not understanding the import is necessary to execute L1012 multiple_video_extraction_responses = await asyncio.gather(*get_responses)

vadakattu avatar Oct 04 '24 08:10 vadakattu

@polong-lin @alokpattani Seems owlbot post processor keeps eating the asyncio import line

Autoflake is removing the import because it's not being used in the notebook. Why is asyncio needed?

@holtskinner the second half of the notebook is about async execution to process multiple videos. It's a problem with the linter not understanding the import is necessary to execute L1012 multiple_video_extraction_responses = await asyncio.gather(*get_responses)

Thanks for that context, I missed the usage. Not sure what's going on here. I'll do some experimentation

holtskinner avatar Oct 04 '24 16:10 holtskinner