generative-ai icon indicating copy to clipboard operation
generative-ai copied to clipboard

Langchain intro - Example - example_selectors fix

Open arindam-b opened this issue 1 year ago • 4 comments

Fix - embedded links in the notebook for example_selectors, text splitter, summarization chain and chain creation in Langchain intro.

arindam-b avatar Jul 06 '23 13:07 arindam-b

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 06 '23 13:07 google-cla[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Hi @arindam-b , thanks for fixing these links! Before we can proceed with merging, you would need to accept and sign the CLA: https://github.com/GoogleCloudPlatform/generative-ai/pull/104/checks?check_run_id=14908796396

polong-lin avatar Jul 10 '23 11:07 polong-lin

Hi @polong-lin, I have accepted and signed the CLA, thanks.

arindam-b avatar Jul 10 '23 12:07 arindam-b

@polong-lin: Another modification was added, this time to the Vertex AI Matching engine index creation. That's why I have modified the PR title and added some details. Could you please review it? Thanks.

arindam-b avatar Jul 24 '23 10:07 arindam-b