Takeshi Furusawa comments

Results 8 comments of


                                            Takeshi Furusawa

fix: consola crashes due to 'logObj.date.getTime is not a function'

I have created an issue as below. https://github.com/unjs/consola/issues/351 It looks like it's currently being worked on. https://github.com/unjs/consola/pull/372

`LogObject.date` should accept a string formatted by a custom date formatter instead of `Date.toLocaleTimeString()`

Hi maintainers, I'd like to propose a fix for this issue. My plan is to add a check before invoking any `Date` instance functions (such as `toLocaleTimeString`). The code would...

`LogObject.date` should accept a string formatted by a custom date formatter instead of `Date.toLocaleTimeString()`

@nozomuikuta Thank you for the suggestion! Extending `BasicReporter` to override `formatDate()` is a smart way to keep the core lean. I appreciate your advice! ご意見いただきありがとうございます！

How make field optional but have minimal character

@hscstudio I think you put empty string. optional() allows undefined and string. "fIeld empty" means 0 character, so you see the error message.

Git Version Typo in Docs

@andriugarcia According to https://git-scm.com/downloads, the current latest version is 2.50.0.

Git Version Typo in Docs

And I've just realized that my PR should be fixed

@jackpeplinski It doesn’t appear to be a typo. Git introduced core.hooksPath in v2.9.0-rc0, so it’s correct that Husky only works with Git v2.9.0 and above. https://github.com/git/git/compare/v2.8.6...v2.9.0-rc0#diff-e0d21ebb9c9c68b408a9e005ad9eff401e9550a8922a5b5b5ba2e523ca99b037R637 However, because the version...