Evgeny Mandrikov
Evgeny Mandrikov
@marchof done!
@marchof I believe that all your previous comments were addressed, so could you please review?
> I only have two minor cleanup proposals. @marchof actually maybe I myself have one more 😆 I have a feeling that maybe better to move `createFor` method into `PreMain`...
> But I need to find a proper name and API Here are some ideas about name: * `InjectedClassRuntimeInstantiator` * we already have some classes with prefix `Support` - `InjectedClassRuntimeSupport`...
@pzygielo Thank you for letting us know! ❤️ I created #1425
@javi-alt set `includes` for `report` goal and not for `prepare-agent`: ```xml org.jacoco jacoco-maven-plugin ... report ...
@javi-alt you can do generation of report using JaCoCo Ant Task `report` (https://www.jacoco.org/jacoco/trunk/doc/ant.html) via maven-antrun-plugin (https://maven.apache.org/plugins/maven-antrun-plugin/)
@ice1000 for the following `RecordExample.java` ``` record RecordExample(int x) { public static void main(String[] args) { new RecordExample(42); } } ``` using ``` openjdk version "17" 2021-09-14 OpenJDK Runtime Environment...
Closing, since this change was done as part of 902ba352c9e70be2b4375948985074ce941e1b5d
Superseded by 4643e7a55de32ac6a1370d4c777cce8c7262bf07