Evgeny Mandrikov
Evgeny Mandrikov
Why not simply introduce new methods, but keep previous for the several releases with annotation deprecated, so to let users migrate ?
@marchof foreseeing your question about why this is still a draft 😉 because the code requires polishing and the addition of in-code comments, I plan to work on this a...
> Can we add a (integration) test case Sure. First of all for such a test case we need a "stable" private JDK API 😆 e.g. `Throwable.setCause` mentioned in #1328...
> As the initialization is specific to the `InjectedClassRuntime`. I wonder whether the code should move there for better encapsulation. This would also allow to only create a class loader...
@marchof To merge conditional jumps where different branches are covered in different instructions we need to determine which branch covered - this is what first change does. Second introduces actual...
@marchof :yum: I suppose that you verified only the fact that there is no exceptions? Verification that we don't merge unrelated lines is easy and doesn't require parsing. I've just...
@marchof @p45q Thanks to both of you! Actually I was thinking about possibility of NPE in `isSame` method, but wasn't able to imagine pair of real source code and bytecode...
@marchof Thanks for the link. What I see so far based only on class file: it has version 45 and `ret` instructions, so that `JSRInlinerAdapter` kicks in before filter. And...
@marchof While fix for NPE in this case is trivial, this raises question about result in case of older compiler versions - in this particular case we'll have false-negative as...
@marchof wow, thanks! However this one violates contract that was already here for method `Instruction.setPredecessor`, in this PR we just added check of this contract. Anyway I'll have a look.