James Hilton-Balfe comments

Results 251 comments of


                                            James Hilton-Balfe

AttributeError: 'H2Connection' object has no attribute '_frame_dispatch_table'

I've also been experiencing this on BetterProto's CI. https://github.com/danielgtaylor/python-betterproto/runs/6114120556?check_suite_focus=true and https://github.com/danielgtaylor/python-betterproto/runs/6114156605?check_suite_focus=true

AttributeError: 'H2Connection' object has no attribute '_frame_dispatch_table'

> @Gobot1234 Fixed your case in https://github.com/vmagamedov/grpclib/commit/d02ef84e6057cf889ed19f396da9325d77ad67b5. As you can see it was caused by `ChannelFor` testing utility - calling `Protocol.data_received` after connection was closed. Thank you!

PyMapping is inconsistent with typing.Mapping

I like the sound of using both the tp flags and the instance checks depending on your version

PyMapping is inconsistent with typing.Mapping

I think the first comment from David is still the best approach

PyMapping is inconsistent with typing.Mapping

Considering this is a wont-fix upstream, could we just implment Davids suggestion to fix this?

Update PyTryFrom for PyMapping and PySequence to more accurately check types

@aganders3 thank you so much for fixing this!

Add ParseFromString for compatibility

There isn't any reason I know of

Documentation errors

I think a PR for this seems like a good idea.

How to wrap in a custom setuptools command?

I think you need to use subprocess to install betterproto using pip at the top of your file but I might be wrong.

Suggestion: use abstract base class and abstractmethod for ServiceBase and/or Stub

This seems like a decent idea. > One question: why user should implement method echo_stream in EchoService while the related rpc method named EchoStream in proto file? Because this project...