Guillaume Giudicelli

Results 438 comments of Guillaume Giudicelli

just checked, builds fine for me as long as remove the old header I forgot to remove in TimedSubdomainModifier

I ll pull your commits today and try it. I built my branch yesterday, I did not see you added commits yesterday.

@grunerjmeier do you have those test inputs? You could create them with your initial version of the PR btw

your branch compiles fine on my machine. Could you try to see if it compiles with ``` cd ~/projects/moose git commit -am "Everything saved" git clean -xfd cd test make...

Thanks for creating the tests! I ll finish this up either this week or early next week. Then I ll be away for a bit I ll probably squash these...

Ok the template should work now on your machine. I was missing a few things. Funny that it still compiled on my machine. Could you please check in the csv...

ok good. I removed the merge commit then worked on making the test lighter. Using less files, less variables and 1st order elements. It's quite small now so all good....

ah ok I should have paid closer attention. i ll change the test again and it should be good after an independent review

going to need a volunteer @grmnptr @lindsayad @tanoret @MengnanLi91

Rebased on next for the conflict. Review should be addressed