moose
moose copied to clipboard
Add physics for two-phase mixture flow
I'm fairly confident it's correctly reproducing the kernels, using the DumpObjectProblem with an upgrade I added
The doco on two phase mixture is a bit lacking now. It would be good to add a page in doc/content/modules/navier_stokes at some point.
Thoughts on first & other phase?
Do you prefer:
- first and second?
- liquid and dispersed?
- main and dispersed?
- dispersed and other?
refs #22637
Job Documentation on 73484b6 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on 73484b6 wanted to post the following:
Framework coverage
ca913d | #27517 73484b | ||||
---|---|---|---|---|---|
Total | Total | +/- | New | ||
Rate | 85.08% | 85.07% | -0.01% | 74.14% | |
Hits | 104117 | 104125 | +8 | 43 | |
Misses | 18265 | 18274 | +9 | 15 |
Modules coverage
Navier stokes
ca913d | #27517 73484b | ||||
---|---|---|---|---|---|
Total | Total | +/- | New | ||
Rate | 84.18% | 84.01% | -0.17% | 69.82% | |
Hits | 17037 | 17329 | +292 | 317 | |
Misses | 3201 | 3298 | +97 | 137 |
Full coverage reports
Reports
-
framework
-
chemical_reactions
-
combined
-
contact
-
electromagnetics
-
external_petsc_solver
-
fluid_properties
-
fsi
-
functional_expansion_tools
-
geochemistry
-
heat_transfer
-
level_set
-
misc
-
navier_stokes
-
optimization
-
peridynamics
-
phase_field
-
porous_flow
-
ray_tracing
-
rdg
-
reactor
-
richards
-
scalar_transport
-
solid_mechanics
-
solid_properties
-
stochastic_tools
-
thermal_hydraulics
-
xfem
Warnings
-
framework
new line coverage rate 74.14% is less than the suggested 90.0% -
navier_stokes
new line coverage rate 69.82% is less than the suggested 90.0%
This comment will be updated on new commits.
going to need a volunteer @grmnptr @lindsayad @tanoret @MengnanLi91
Rebased on next for the conflict. Review should be addressed
That distributed failure is concerning. It's on the same model as affected by the 5 ghost layer requirements valgrind isnt saying anything https://civet.inl.gov/job/2246126/
a lot of sanitizer failures tsan.log
should be ready
Thanks for the review!