moose icon indicating copy to clipboard operation
moose copied to clipboard

Add physics for two-phase mixture flow

Open GiudGiud opened this issue 9 months ago • 6 comments

I'm fairly confident it's correctly reproducing the kernels, using the DumpObjectProblem with an upgrade I added

The doco on two phase mixture is a bit lacking now. It would be good to add a page in doc/content/modules/navier_stokes at some point.

Thoughts on first & other phase?

Do you prefer:

  • first and second?
  • liquid and dispersed?
  • main and dispersed?
  • dispersed and other?

refs #22637

GiudGiud avatar May 01 '24 01:05 GiudGiud

Job Documentation on 73484b6 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar May 09 '24 23:05 moosebuild

Job Coverage on 73484b6 wanted to post the following:

Framework coverage

ca913d #27517 73484b
Total Total +/- New
Rate 85.08% 85.07% -0.01% 74.14%
Hits 104117 104125 +8 43
Misses 18265 18274 +9 15

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

ca913d #27517 73484b
Total Total +/- New
Rate 84.18% 84.01% -0.17% 69.82%
Hits 17037 17329 +292 317
Misses 3201 3298 +97 137

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 74.14% is less than the suggested 90.0%
  • navier_stokes new line coverage rate 69.82% is less than the suggested 90.0%

This comment will be updated on new commits.

moosebuild avatar May 12 '24 04:05 moosebuild

going to need a volunteer @grmnptr @lindsayad @tanoret @MengnanLi91

GiudGiud avatar May 14 '24 15:05 GiudGiud

Rebased on next for the conflict. Review should be addressed

GiudGiud avatar May 22 '24 17:05 GiudGiud

That distributed failure is concerning. It's on the same model as affected by the 5 ghost layer requirements valgrind isnt saying anything https://civet.inl.gov/job/2246126/

GiudGiud avatar May 23 '24 03:05 GiudGiud

a lot of sanitizer failures tsan.log

lindsayad avatar May 23 '24 14:05 lindsayad

should be ready

GiudGiud avatar Jun 13 '24 15:06 GiudGiud

Thanks for the review!

GiudGiud avatar Jun 14 '24 01:06 GiudGiud