Guillaume Giudicelli

Results 438 comments of Guillaume Giudicelli

pls ping me when you want another review

@maxnezdyur I m going on travel. If you cant wait 2 weeks on this please work with someone else in the team to get this in

First picture is 5.5 rings Yes it possible this check is off by 1

Happy to review a patch if you feel comfortable making it

that's a larger rework than I want to do for this maintenance action. But I ll keep it in mind next time I use the reader

Looks like Grizzly hardcoded the reading of centers from another file. This wont be ready until I find a clean way to reconcile this

@dschwen adding the offset goes directly against having titles for columns (of the coordinates) so I removed that from the PR I tried having titles. I did not finish, there's...

The API definitely cant be requesting those 3 numbers, the system is meant to be more general than that. I think being able to produce convergence decisions for both the...

Please ping me if you want a review btw. This is something I care about