moose
moose copied to clipboard
idaholab
Fixup CSV data reading, when data is organized in Voronoi partittions, to make it clearer
to both devs (no need to code an offset) and users of the function (just look at the column in the file)
I m also freezing the number of columns for the coordinates of the centers to Moose::dim (3 for all intents and purposes) This is probably also reducing the risk of errors
refs #19109
Job Documentation on 40486af wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on 40486af wanted to post the following:
Framework coverage
| 6a80be | #27050 40486a | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.12% | 85.12% | -0.00% | 100.00% | |
| Hits | 102894 | 102893 | -1 | 1 | |
| Misses | 17982 | 17983 | +1 | 0 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
A while ago I added https://github.com/idaholab/moose/pull/21208 . That would be my preferred way over column indices.
that's a larger rework than I want to do for this maintenance action. But I ll keep it in mind next time I use the reader
Looks like Grizzly hardcoded the reading of centers from another file. This wont be ready until I find a clean way to reconcile this
@dschwen
adding the offset goes directly against having titles for columns (of the coordinates) so I removed that from the PR I tried having titles. I did not finish, there's some painful work to do in the DFR to handle headers in now both rows and columns.
the PR now only hardcodes the dimension 3, which will still be good for porting simulations between dimensions. It s very limited but I trust it can be merged.