Manuel Beck

Results 146 comments of Manuel Beck

You can use github-links with tags: `cordova plugin add https://github.com/katzer/cordova-plugin-local-notifications#v1.0.0`

I added the possibility to change the account name in the new fork https://github.com/GitToTheHub/cordova-plugin-calendar-2. If the account name is not set, the app name will be used.

Hi, did you miss something with this PR? You added the method `triggerInForeground` but it is not used anywhere.

Thanks. Can you comment what this code does and why it is there? ```java if(LocalNotification.isInForeground() && !options.triggerInForeground()) return; ``` Can you document the foreground property in the readme?

Thank you, now it would ne nice, if you also would document the if condition you added.

Hi @dpa99c, would you mind if you would make the changes to this PR so I can merge it? Thanks.

Hi @dpa99c, I checked to support `foreground` in Android. The correct behavior would be, to trigger the notification with the sound, vibration and badging, but not show it visually. In...

Can you please explain, what your code does? Have the user something to setup? Why do you have this code in this PR: ```javascript if(LocalNotification.isInForeground() && !options.triggerInForeground()) return; ``` It...

Now it would be nice, if would explain, what your code does. Can you rename `applyDayNightToIconFilename` to `getDarkLightIconFilenameForCurrentUIMode`, because you add `dark` & `light` for the current UIMode. How can...