Manuel Beck

Results 146 comments of Manuel Beck

This PR is wrong sorry, because I was confused about these things: - `CordovaActivity.onRequestPermissionsResult` calls `CordovaInterfaceImpl.onRequestPermissionResult` without an `s`. `CordovaInterfaceImpl.onRequestPermissionResult` should be renamed to `CordovaInterfaceImpl.onRequestPermissionsResult` - `CordovaInterfaceImpl.onRequestPermissionResult` calls the deprecated...

This was only to indicate, that I did something wrong but want to correct it. I will correct it now :)

Hi @erisu, I was marking this pr before as "faulty" because I thought I mixed something up. But when I researched the Code to document the deprecated `CordovaPlugin.onRequestPermissionResult` and the...

I created two PRs to clear these things: https://github.com/apache/cordova-android/pull/1855 and https://github.com/apache/cordova-android/pull/1856

There is also an open issue on the Chromium project on Google: https://issues.chromium.org/issues/414259802

When I look on the Google documentation for [Hardware acceleration](https://developer.android.com/develop/ui/views/graphics/hardware-accel), it says: > Hardware acceleration is enabled by default if your Target API level is >=14, but can also be...

Hi, this will be fixed with cordova-android 15. You already can test it via `cordova platform add android@nightly`

Hi @breautek, was I wrong with my suggestions? I thought the `engines` tag is obsolete in `config.xml`. Also the configuration `"cordova": ">100"` seems odd to me. Is this a correct...

> Nope, it's not obsolete. It controls some checks on the Cordova CLI, and/or platforms when installing cordova plugins. Why does the [documentation](https://cordova.apache.org/docs/en/12.x-2025.01/plugin_ref/spec.html#engines-and-engine).) say for the `plugin.xml` `engines` tag: >...

Thanks, I forgot about this link. So it's only to protect people installing a plugin which is maybe not compatible anymore with old cordova cli versions. For people who don't...