Juan Russell

Results 14 comments of Juan Russell

I'm doing some refactors to this project and I have the same issue: ``` 20:01:46.285 [DEBUG] [TestEventLogger] 20:01:46.285 [DEBUG] [TestEventLogger] Gradle Test Executor 1 STARTED 20:01:46.291 [DEBUG] [TestEventLogger] 20:01:46.291 [DEBUG]...

Awesome @kkoser, I can confirm the workaround [works](https://github.com/GianpaMX/MockMakerIssue/tree/workaround) Thank you,

is a snackbar too big? Another option I was thinking is to just add a small view below the recycler view

I was thinking to use the feature of the `CoordinatorLayout` that moves up the floating buttons ```diff diff --git a/app/src/main/java/com/kunzisoft/keepass/activities/stylish/StylishActivity.kt b/app/src/main/java/com/kunzisoft/keepass/activities/stylish/StylishActivity.kt index 32904c342..ac5660d0f 100644 --- a/app/src/main/java/com/kunzisoft/keepass/activities/stylish/StylishActivity.kt +++ b/app/src/main/java/com/kunzisoft/keepass/activities/stylish/StylishActivity.kt @@ -25,9...

Great I'll continue working on PR #1371 and I might tag you over there with specific questions

Hey @J-Jamet, my PR is ready for review

oh! I see. What would be the best way to get my code merged? Should I rebase it on top of `develop` and edit my PR to target `develop` instead...

Release 3.5.0 has 25 cards in to-do, any chance to add this to that release? I think by the time all those cards are done this PR will be too...

> It will be even more complicated to debug if there are blocking bugs added during the architecture change, believe me I believe you. > I will check each feature...

Hey @J-Jamet, I saw the [3.5.0 beta release](https://github.com/Kunzisoft/KeePassDX/releases/tag/3.5.0beta01) how is the plan going? In which commit should be good to start the database extraction task?