Gheis Mohammadi

Results 10 comments of Gheis Mohammadi

Could you please add a description and explain what this PR does and why we need that?

It seems there were some sort of aggregation on metrics. We found out that some of the nodes are using same instance id. All of the metrics firstly are grouping...

> @GheisMohammadi , should we close this PR? Yes, please, It is refactored already (#4316) and merged with dev. thanks

> hey @GheisMohammadi can you review this one, what do you think ? This is old stream sync code which pr #4408 will remove them eventually. We are not using...

> hey @GheisMohammadi those new settings are advanced p2p configuration, can you please hide them in the config file ? I believe they are needed to be customized by user....

some of the PRs here are not squash merged. So, many of the similar vague commits like "Added logs" or "Fixed Imports" are merging like a PR.

> @GheisMohammadi have you tested it on devnet/testnet or even on a test mainnet node ? ie once the pruning is completed is the harmony process still without issue ?...

> hey @GheisMohammadi a few things, > > 1. could you rebase that PR with the latest dev > 2. the latest harmony config has the below > > ```toml...

> @GheisMohammadi Able to fix the last conflict? This PR is for the time that we haven't started changes on stream sync. I just make it draft, once stream sync...