Liam Gerrior

Results 12 comments of Liam Gerrior

Hi @scottwdavis as previously said we need to see a test can can cover the changes made to the regex to ensure any future changes don't break it. Since the...

Perhaps it would be better to capture it and add it to the schema as an Optional() key. That way it will get captured and recorded if it's there and...

Hi Yannick, If you have opened a new PR with a different email, could you please comment the link to the new PR?

Hi @jmdilly sorry for the delay, could you please catch your fork up to the main repo so we can get this merged for you?

Hi viktklass, Thank you for bringing this to our attention. Since you have already found a solution you're welcome to open a PR with your fix, but we can also...

https://pubhub.devnetcloud.com/media/pyats-development-guide/docs/writeparser/writeparser.html#regex-parser If you haven't read it already you might find this document helpful. Otherwise we look forward to your PR!

https://pypi.org/project/pyats/22.3/#files pyATS 22.3 now supports M1 for Python 3.8+

Thanks for your contribution! Unfortunately there are a couple things that need to be addressed before it can be included

@einarnn I've added another upstream fix. Is it possible to get a review?

We released the 23.3 version of pyats - try merging the latest copy of our master branch into yours, and then pushing that merge commit.