Vladislav Shpilevoy

I tried to find which arguments they take and just couldn't. In the examples and in the code I couldn't find anything. Attempts to print the arguments resulted into messages...

Can't use global variables on storages when use `:exec()`

2

In `exec()` functions on the instances I can't save any global parameters conveniently. Because of that I need to return stuff from `exec()` funcs and pass it back into another...

`retrying()` function is unhandy

3

`retrying()` takes options as a first argument. It is almost never needed non-default. As a result, nearly all calls of `retrying()` are going to start with `{}`. The options must...

The reason is that it thinks it will call `eval([[return pcall(...)]]` internally and drops first returned value. But with `is_async` the first returned value is the future object. It shouldn't...

Describe code style

1

The current description in the readme is quite vague. Need a more detailed guide.

Currently the benches run for `mg::serverbox::TaskScheduler` and for a trivial lock-based scheduler without any features. Would be interesting to implement a scheduler similar to `mg::serverbox::TaskScheduler` in terms of feature set...

Currently we only bench it with a single producer + various number of consumer threads. But would be interesting to see what if producer thread count is > 1. I...

It is an optimized version of a boolean flag + a condition variable. Works like a one-byte pipe, a channel. Need to bench it against plain mutex + condvar +...

That should also automatically support Apple M1/M2.

Update journal vclock only in box.cc

4

See #9916, #10113, and commit messages. Notes for reviewers: * I added tests to existing files. They were fitting too good, didn't want to create new file for that. *...