George

Results 88 comments of George

That is pretty spot on, the only change is that it is the full string “reference” instead of “ref”.

Great shout. My 2 cents would be to err on the side of make it a parameter of flag (on CreateFlag, UpdateFlag). This is a property of flag, could also...

It definitely wouldn't be hard to add an overloaded return type here. We could continue with the pattern we've started, but use `oneOf` in proto to support an evaluate for...

I totally see where you're coming from. FF's are kind of a variable (flag) that is stored in a remote service. Where the server itself can't protect the client side...

Very reasonable. I think (since we addressed some feedback) that with the declarative backends you now get an error when validating your config when this referential constraint is violated. So...

I think JSON (when over HTTP) would be the most appropriate format for both endpoints. We could just create a parent object and either have a list or object (keyed...

Here are all the tags and the marshal / unmarshal funcs for segment types: https://github.com/flipt-io/flipt/blob/gm/oci/internal/ext/common.go

Infact, if you implement it as a one way grpc stream, gateway will just map that onto a newline delimited JSON stream for HTTP: https://github.com/grpc-ecosystem/grpc-gateway#supported

Morning @ericvdberge ! Great suggestion. Pushing state to clients is something we’ve talked about before. Can definitely see the value there. Just to clarify in your example. When you say...

Thanks for the suggestion @Jamess-Lucass 🙏 This is, I believe, really similar to a concept we have thrown around internally that we call client-side evaluation. (correct me if I am...