George

Results 88 comments of George

Good to know. I was using it to print unix timestamps, and then another system was expecting those timestamps to be precisely as expected. I moved away from relying on...

We have support for OIDC and token authentication as of `v1.18.0`. Enjoy.

Hey @endigma . You are right that Github doesn't support OIDC. We put the breaks on adding Github as no one has yet to actually request it. However, it was...

Going to link in some comments from other issues, as we've danced around this idea a couple times. - https://github.com/flipt-io/flipt/issues/1730#issuecomment-1598482037 (in particular the "Potential Future Changes For Flipt" section). -...

I should've read your other issue first 😄 I see you've answered my question there. https://github.com/flipt-io/flipt/issues/2113 I will write some suggestions in that issue for your consideration. As I think...

cc @jalaziz as I know we spoke about this in the past. Might be of interest to you 👍

Keeping it simple is a great shout for first pass. Might even be that we don't even have conflict support, maybe we just choose the PR route and eventually bring...

Thanks for raising this @snv ! Sounds like some over-zealous yup schema in the input there. The server side rule for all backends (declarative and relational) has always been: https://github.com/flipt-io/flipt/blob/main/rpc/flipt/validation.go#L55...

Not the yup schema but the onChange for this field is rewriting it without uppercase: https://github.com/flipt-io/flipt/blob/f9978cf13f7a1e1cdc1128802a5c7206a9726976/ui/src/components/flags/FlagForm.tsx#L174-L177 Here https://github.com/flipt-io/flipt/blob/main/ui/src/utils/helpers.ts#L26

We appear to only use this in segment, namespace and flag creation and I believe in all situations upper-case is fine. So I think we can just drop the `toLowerCase()`...