Dimitris Xenakis

Results 71 comments of Dimitris Xenakis

Placed couple comments here **General note:** If you agree with those and proceed resolving them (with tests passing), please remove the `changes-required` label so it is easy for reviewers to...

There are some type checking issues needed to be addressed first.

Can you rebase please? I can give it a check.

Isn't the Hermès bulk path change breaking the backward compatibility?

> > Isn't the Hermès bulk path change breaking the backward compatibility? > > I belive not. The path is configurable. And works for elastic7 as it was before as...

Note for future PRs: whenever you think that no changes are required and tests are passing, feel free to remove that label on your own. It would be quicker for...

The ruff error is unrelated and is being handled by #8269, #8267 and #8265.

> > The ruff error is unrelated and is being handled by #8269, #8267 and #8265. > > The error is because of a trailing space on the docstring `lib/rucio/client/scopeclient.py:105:73`...

> What I don't get, is this only done for testing? I assume so, but in this case, I think this needs to have a clearer name. When I read...