Dimitris Xenakis
Dimitris Xenakis
To support the review of this PR, I summarise below the changes introduced by the new DDL helper modules added alongside the refactored migrations. This document could be also used...
Hmm, integration tests are failing: FAILED tests/test_conveyor.py::test_receiver_archiving[caches_mock0] - AssertionError: assert 'FAILED' == 'ARCHIVING' FAILED tests/test_conveyor.py::test_transfer_with_tokens[file_config_mock{'oidc': {'admin_issuer': 'indigoiam'}}] - assert False
> After doing an offline review with @bari12 , I will do some significant refactoring of the changes. I will mark it as ready again when done. Is this ready...
The new hard dependency on `opendata.rse_expression` breaks the backward compatibility but I am not sure how critical that is. You don't think of any problem there, right?
The patch is named after https://github.com/rucio/rucio/issues/8228 but you (and me too now in the title) are linking manually https://github.com/rucio/rucio/issues/8215 . Is this correct? Will/should it close both?
The caching stores results for two hours but what about high-frequency dataset mutations or replica changes? Should any cache-invalidation be used here to avoid incorrect reported data during this window?
Could you resolve the conflicts please?
Some `ruff` checks to be fixed pending.
Problems to be addressed pending
P.S. I already have something working that I can push as a draft.