Geoffrey Booth

Results 425 comments of Geoffrey Booth

This seems fine. Any idea why the prior implementation was written the way that it was? Or put another way, are there any disadvantages of this refactor? Also wouldn’t `referencedVars`...

> I imagine the original initialization is also somewhat faster I ran `cake bench` on this branch and on `main` and sometimes this branch was faster, sometimes `main` was. So...

> I’m excited for this! Is there anything I can do to help? This one was pretty much ready to merge, but I was hoping it could get another reviewer....

If you’d like to tackle this, https://github.com/jashkenas/coffeescript/issues/5366#issuecomment-922400143 has some links to get you started. I also see that issue, about outputting JSDoc comments properly, as a high priority.

You might want to dig a little to find where this behavior was added, and why. There might be something particular about `catch` blocks that led to this, as it’s...

Good catch. I guess this can be the workaround for now: ```coffee {foo, bar} = item export {foo, bar} ```

This one is fine too, it just needs a rebase.

Run `cake release` to fully update everything. I put a note on the other version of this, is there a way to handle this without introducing a new rewriter pass?...

One of the primary reasons for adding support for new features is compatibility. Users shouldn’t need to have to choose between CoffeeScript and Svelte, for example; we added support for...

The Svelte syntax is `$:`, which we can’t use because it already compiles; but `:$` is available. How do these look? ```coffee # https://svelte.dev/tutorial/reactive-declarations :$ doubled = count * 2...