coffeescript icon indicating copy to clipboard operation
coffeescript copied to clipboard

Allow leading logical operators

Open helixbass opened this issue 5 years ago • 4 comments

@GeoffreyBooth re-opening against master

See original PR: #5068

helixbass avatar Dec 30 '19 20:12 helixbass

This one is fine too, it just needs a rebase.

GeoffreyBooth avatar Jan 26 '22 04:01 GeoffreyBooth

I like this proposal, let me know if there is anything I can do to help.

STRd6 avatar Apr 04 '22 22:04 STRd6

Hi guys, sorry I've been MIA on Coffeescript stuff, mostly been focusing on other things

I merged main into this branch and see bin/cake test passing locally but CI appears to be failing on git diff --exit-code, is there a different set of local rebuilds I should be doing to get "matching" lib/*.js output (I was testing against and committed the output of git checkout lib && bin/cake build:except-parser && bin/cake build:parser)?

Also the details of this PR are a bit fuzzy but I'd tend to trust my past self 😜

helixbass avatar Apr 08 '22 19:04 helixbass

Run cake release to fully update everything.

I put a note on the other version of this, is there a way to handle this without introducing a new rewriter pass? It feels like something that should be doable within the lexer.

GeoffreyBooth avatar Apr 08 '22 20:04 GeoffreyBooth