Mathias LANG
Mathias LANG
I think at the moment, splitting things in libconsensus might slow down development, hence why I'm not eager to do it.
Depends on #365
We can delay this until after CoinNet since it is not required for consensus to be sound.
Return by value is actually fine, it uses NRVO so dtor / copy ctors are not involved
Re unwanted moves, on the C++ side we have https://reviews.llvm.org/D43322 (flag `-Wreturn-std-move`).
I consolidated everything in the first post and removed the 6 or so comments. There have been quite a few improvements we made, and there's quite a few left to...
We won't have this for CoinNet, as it's a major protocol change. Moved to the `MainNet` release.
This is testing only, and we know it works, so changing the milestone.
I've re-purposed this issue to be about generating a correct `CoinNet` block (and probably `TestNet` as well).
We worked a bit on that issue, and managed to get a function that accessed the `Ledger` called from WAT (WebAssembly Text) 💥 Key findings: - Binding is done outside...