Mathias LANG

Results 625 comments of Mathias LANG

This issue could use a description as well.

My only comment so far is that the signature should be a hash of the date + the receiving node's public key, otherwise there's an obvious vector for replay attacks.

> Unless the node is fully synced yet, it should store confirmed block without validation temporarily. Why does it needs to bypass validation ?

I see, it makes perfect thanks, thanks for the clarification!

@outsideris : See https://github.com/bosnet/sebak/issues/434 The problem is that the JSON is not what's used for hashing, it's the Go-side data structure. Currently when we send a request, if the `linked`...

A simple fix for this situation would be `if [ ! -d vendor ]; then dep ensure -v; done`

@soonkuk: Yes, we agree on this. The initial transaction is the request for unfreezing, then after the timeout the proposer generates the actual state change.

Cross ref: - https://github.com/bosagora/agora/pull/1830 - https://github.com/bosagora/agora/issues/1443

@hewison-chris : Looks like Faucet was deleted / made private and that broke the CI.