Genuster

Results 16 comments of Genuster

> I think commenting this out likely causes all the other problems Yeah, I completely understand that this is a poor way to solve the problem. It's just too complicated...

@drammock I'm sorry about that, it sounds really nasty. I've uploaded it to the google drive, here is the [link](https://drive.google.com/file/d/1dZG9E4-bB68GQQ1OyTg2dLzlPWKwVP_s/view?usp=share_link). I hope it will work well.

Thanks! Interesting how it passed macos-13/mamba/3.12, but didn't pass macos-latest/mamba/3.12 It might be that the small difference between filters_ will propagate and increase in patterns_, so rtol/atol won't be much...

@larsoner, I think I covered tests for the core GEDTransformer cases. Could you check that it's enough and I can move to the next step?

Thanks Eric! > Great that the `assert` statements are passing! Just a few comments below. Also, can you see if you can get closer to 100% coverage here? > https://app.codecov.io/gh/mne-tools/mne-python/pull/13259...

Hi @larsoner! Is there anything else I should improve before moving on to the next steps? Also, could you please confirm that I'm not confused with these two? > -...

> I think this should be okay. Is the sorting by variance explained or something? Before they're sorted how are they ordered? If it's random for example it's fine to...

> If this were true test-driven development (TDD) you could for example make this your first commit, show it failed on CIs, then proceed to fix it in subsequent commits....

Thanks Eric! I tried (1) and didn't replicate the failure with the CI's versions of python, numpy an OpenBlas (setting up conda was pain :)) (4) seem to work, so...

Hmmm, current fail doesn't seem to be relevant to this PR. Anyway, I started thinking and playing with the last point in the plan: >perhaps ssd should use mne.cov.compute_whitener() instead...