Julian Geiger comments

Results 88 comments of


                                            Julian Geiger

Add `get_total_size_on_disk` method to `RemoteData`

Note to self to run `du` via `exec_command_wait` method from `transport`.

Add `get_total_size_on_disk` method to `RemoteData`

Thanks for the review, @agoscinski! I'm currently still working on this, will ping you once it's again ready for review. > I think the output of du --apparent-size is the...

Add `get_total_size_on_disk` method to `RemoteData`

OK, this should be ready for a final review, @agoscinski and @khsrali. Also pinging, @mikibonacci, if you want to provide some feedback on the CLI/API for use in AiiDAlab?

Add `get_total_size_on_disk` method to `RemoteData`

Thanks again for the review, @khsrali, I implemented your proposed changes.

Add `get_total_size_on_disk` method to `RemoteData`

Thanks again for the review, @khsrali. I wrote down my reasoning for point 1 in my response to your comment in the code, and implemented point 2. Once CI passes...

Decrease `_DEFAULT_SAFE_OPEN_INTERVAL` (to what?)

Yes, good point, it should be changed in the `SshTransport` instead. I think most users, especially new ones, will just be running with the default value. Especially if they go...

Decrease `_DEFAULT_SAFE_OPEN_INTERVAL` (to what?)

The benchmarks by @khsrali can be found here: https://github.com/aiidateam/aiida-core/issues/6544#issuecomment-2407529994

Decrease `_DEFAULT_SAFE_OPEN_INTERVAL` (to what?)

Hi @khsrali, thanks for the ping here! Before we actually merge this change, I'd like to do some proper benchmarking (e.g., with Thor). That's why this has been on hold...

Make `safe_interval` more dynamic for quick transport tasks

Closing this for now, as it would require a more major effort. We'll integrate #6599 instead.

Add `is_file` property to `RemoteData`

Hi @agoscinski, thanks for the input! Agree with all points, this was a very low-effort PR :D Though, the more I think about this, the more I think we should...